Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Experiment Filters for Invitations #258

Merged
merged 11 commits into from
Nov 24, 2023
Merged

feat: Add Experiment Filters for Invitations #258

merged 11 commits into from
Nov 24, 2023

Conversation

leostera
Copy link
Collaborator

@leostera leostera commented Nov 17, 2023 •
edited
Loading

Still working here, opening to gather notes. So far:

  • New hardcoded field for Invitations
  • Adds a subquery for listing invitations
  • Creates a temporary table for Invitations
  • Add support for Assignments – we will add assignment filtering in the next PR
  • Create integration test for different filters

Like #256 this PR builds on to of #257, so once #257 is merged, I'll clean up the history here.

@leostera leostera force-pushed the feat/add-experiment-filters-1 branch 3 times, most recently from e7ebde3 to 2ad596a Compare November 21, 2023 03:51
@leostera leostera force-pushed the feat/add-experiment-filters-1 branch from 3a2791f to cb90b56 Compare November 23, 2023 04:10
leostera
leostera commented Nov 23, 2023
View reviewed changes
pool/app/filter/entity.ml Outdated Show resolved Hide resolved
@leostera leostera marked this pull request as ready for review November 23, 2023 10:55
@leostera leostera changed the title feat: Add Experiment Filters for Assignments and Invitations feat: Add Experiment Filters for Invitations Nov 23, 2023
@leostera
Copy link
Collaborator Author

@mabiede feel free to squash and remove some of the commit messages in the process :)

mabiede
mabiede requested changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@mabiede mabiede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks. Added a few comments about left overs and adjustments to the consistency

pool/app/filter/repo/repo.ml Outdated Show resolved Hide resolved
pool/app/filter/repo/repo.ml Outdated Show resolved Hide resolved
pool/app/pool_user/entity.ml Outdated Show resolved Hide resolved
pool/test/test_utils.ml Outdated Show resolved Hide resolved
@leostera leostera mentioned this pull request Nov 24, 2023
Merged
4 tasks
@mabiede mabiede merged commit e950928 into main Nov 24, 2023
5 checks passed
@mabiede mabiede deleted the feat/add-experiment-filters-1 branch November 24, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabiede mabiede mabiede approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leostera @mabiede